修改 contract.json 的 LibString.sol 部分 删去了无用的代码#890
Open
allureluoli wants to merge 2 commits intoWeBankBlockchain:masterfrom
Open
修改 contract.json 的 LibString.sol 部分 删去了无用的代码#890allureluoli wants to merge 2 commits intoWeBankBlockchain:masterfrom
allureluoli wants to merge 2 commits intoWeBankBlockchain:masterfrom
Conversation
原代码产生了不必要的内存浪费
```solidity
function bytesToString(bytes memory _bytes) internal pure returns (string memory){
_bytes memory bytesArray = new bytes(_bytes.length);
for (uint256 i; i < _bytes.length; i++) {
bytesArray[i] = _bytes[i];
}
return string(_bytes);
}
```
删去了四行已减少内存占用并节省gas费
```solidity
_bytes memory bytesArray = new bytes(_bytes.length);
for (uint256 i; i < _bytes.length; i++) {
bytesArray[i] = _bytes[i];
}
```
原代码产生了不必要的内存浪费
```solidity
function bytesToString(bytes memory _bytes) internal pure returns (string memory){
_bytes memory bytesArray = new bytes(_bytes.length);
for (uint256 i; i < _bytes.length; i++) {
bytesArray[i] = _bytes[i];
}
return string(_bytes);
}
```
删去了四行已减少内存占用并节省gas费
```solidity
_bytes memory bytesArray = new bytes(_bytes.length);
for (uint256 i; i < _bytes.length; i++) {
bytesArray[i] = _bytes[i];
}
```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
原代码产生了不必要的内存浪费
删去了四行已减少内存占用并节省gas费