fix: don't use module-level logging methods#46
Conversation
Calling these methods might add handlers to the root logger, which can interfere with applications that don't use it. Fix WSH032#45.
|
Thanks, LGTM. Would you mind making them private? _logger = logging.getLogger(__name__)The new version |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #46 +/- ##
==========================================
+ Coverage 96.96% 97.41% +0.45%
==========================================
Files 9 9
Lines 461 464 +3
Branches 44 35 -9
==========================================
+ Hits 447 452 +5
+ Misses 9 7 -2
Partials 5 5 ☔ View full report in Codecov by Sentry. |
|
The test for Except for reporting this issue to If you are ready, I can use admin privileges to bypass this check. After all, it only fails in EDIT: I just remembered that this bug was fixed in So I am going to drop support for I call it a day. I will do it tomorrow. |
|
CI passed, do you have any other changes? |
Calling these methods might add handlers to the root logger, which can interfere with applications that don't use it.
Fix #45.
Checklist
CONTRIBUTING.md.