fix: scrollbar width #91
Conversation
WalkthroughUpdated a timestamp in Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (3)
data/info.json(1 hunks)package.json(1 hunks)site/styles/common.css(1 hunks)
🔇 Additional comments (1)
data/info.json (1)
1-1: Confirm timestamp semantics to avoid noisy diffs.Hash unchanged but
timestampadvanced. Iftimestampdrives “Last updated” UI without content change, that’s fine; otherwise consider updating only when data changes to reduce churn.
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
package.json (1)
39-40: Relax engines to a realistic LTS floor; 22.19.0 is likely unnecessarily high.Pinning to Node ≥22.19.0 will exclude contributors/CI on Node 20 LTS without providing clear benefit. Given your toolchain, suggest using Node ≥20.17 (meets lint-staged v16.x) and a less specific npm floor. If you need “stable fetch” from core, require Node ≥21 explicitly; otherwise Node 20 LTS is sufficient (native fetch is stable from Node 21, and earlier 18.x had it before stabilization). (github.com, devclass.com)
Apply:
"engines": { - "node": ">=22.19.0", - "npm": ">=10.9.3" + "node": ">=20.17.0", + "npm": ">=10" }Confirm your CI/workflows actually run Node ≥20.17 before merging (see script above).
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
package.json(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: TobiTenno
PR: WFCD/warframe-drop-data#91
File: site/styles/common.css:34-35
Timestamp: 2025-09-04T05:24:13.137Z
Learning: TobiTenno prefers simple CSS solutions over cross-browser compatibility and explicitly dislikes supporting IE. They are okay with Firefox-specific CSS properties like `scrollbar-width: none;` even if it doesn't work in Chromium-based browsers.
🔇 Additional comments (1)
package.json (1)
20-27: The above script will list and inspect all CI workflow files, Dockerfiles, and the project’s Node version manager file to confirm that Node ≥20 is enforced across all relevant configs.
Warframe Drop Data Site Pull Request
What I did:
hide the scrollbar
Why I did it:
cause it's uggo
Fixes issue (include link):
the scrollbar was uggo
Mockups, screenshots, evidence:
Was this an issue fix or a suggestion fulfillment?
Summary by CodeRabbit
Style
Chores