Conversation
|
For reference, issues this is picking up with v0.10.0 of the mapper and DR v1.2.2 Details |
wolfiex
left a comment
There was a problem hiding this comment.
Can we move the requirements.txt to the scripts folder?
|
Sure. Thoughts on the question raised here: #37 (comment) ? I can do link, ID, file structure validation separately (as that can be used across all repos. Branding validation as a separate script makes sense here with any other more specific (science based) checks. I would probably also make sure the labels entries match the constructed id as part of it too. |
|
If we are running it continuously, I would make it produce a pretty md report, and have a flag to create an issue outlining the problems it finds. |
|
That's an option. Surely it's better to just run it as a validation step in CI so that we never merge anything with broken information in the first place (if you fail CI, don't merge). |
Just a demo script for now. @wolfiex should I turn this into a validation script (returns 0 if all good, 1 if not) and associated GitHub action or do you want to handle this validation another way?