Port colors module to new build system #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Looks good :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a bid to contribute to your PR to overhaul MESA's build system, here's my initial pass at porting the
colorsmodule. I referred to the commit where thechemmodule was ported.I've done a few round trips of
./clean,make cleanand rebuilding with./installand I think I've got everything we need but I probably haven't deleted everything that can be deleted. I've also been running the defaultstar/workfolder and just ran thecustom_colorstest successfully for good measure.If I've got this right, then I'm happy to help port some more modules in this way. I.e., by opening MRs against your umbrella MR into MESA itself.