Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the image generation model utilized by the LLM service. The change specifically targets the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the image generation model to a newer preview version. My feedback focuses on improving maintainability by suggesting that the hardcoded model name be moved to a configuration variable, consistent with how other models are handled in the project. This will make future updates easier and reduce risks associated with using preview models.
| Returns raw image bytes (base64 string) on success or error message. | ||
| """ | ||
| image_model = "google/gemini-2.5-flash-image" | ||
| image_model = "google/gemini-3.1-flash-image-preview" |
There was a problem hiding this comment.
While updating the model is the goal of this PR, hardcoding the model name here makes it difficult to manage and update in the future, especially for a model in 'preview'. It's inconsistent with how OPENROUTER_MODEL is handled. Consider moving this to a configuration variable (e.g., OPENROUTER_IMAGE_MODEL in config.py) and initializing it in the LLMService constructor. This will improve maintainability and align with existing patterns in the codebase.
No description provided.