Fix some pedantic clippy warnings to reduce code length #425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscargus
force-pushed
the
clippyshortening
branch
from
1fb1917 to
2fdd0c2
Compare
oscargus
force-pushed
the
clippyshortening
branch
from
2fdd0c2 to
080f29a
Compare
Schottkyc137
reviewed
Jan 4, 2026
|
|
||
| match quoted_inner() { | ||
| Ok(_) => {} | ||
| Ok(()) => {} |
Contributor
There was a problem hiding this comment.
Why is this better? (Not against this change, just curious)
Schottkyc137
reviewed
Jan 4, 2026
| related_information.push(DiagnosticRelatedInformation { | ||
| location: Location { | ||
| uri: uri.to_owned(), | ||
| uri: uri.clone(), |
Contributor
There was a problem hiding this comment.
What is the advantage of using clone instead of to_owned?
Schottkyc137
reviewed
Jan 4, 2026
Contributor
Schottkyc137
left a comment
Schottkyc137
left a comment
There was a problem hiding this comment.
Nice! I like these kinds of changes that leave the repo with more succinct code.
I have left a few comments, but they are mostly for my understanding. Happy to merge this soon. Thanks for the contribution!
Schottkyc137
approved these changes
Jan 4, 2026
Contributor
Author
|
Sorry for not getting back on this. These are all pedantic clippy warnings, so I think that the things you asked about are mainly related to consistency and someone has decided that the suggested form is the preferred one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Focused on things that resulted in less code.