Move to use workspace dependencies and remove pad dependency #424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscargus
force-pushed
the
workspacedeps
branch
from
5e3c253 to
eeedcb2
Compare
oscargus
force-pushed
the
workspacedeps
branch
from
eeedcb2 to
fe3c07f
Compare
Schottkyc137
reviewed
Jan 4, 2026
Schottkyc137
approved these changes
Jan 4, 2026
Contributor
Schottkyc137
left a comment
Schottkyc137
left a comment
There was a problem hiding this comment.
Thanks! These changes look good to me.
I think the code should be tested since it's used in SrcPos::show which is tested in the source.rs file.
At some point, we should probably also add a coverage stage to the pipeline to have a better understanding of what code is actually tested...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although there are not that many overlapping dependencies between the crates, it still gives a better overview if all are available in the workspace Cargo.toml when it comes to updating etc.
Removed the use of the
padcrate. Closes #401 (not sure if it is tested, but should be the same if I understand the code).Also updated a few dependencies, primarily to get rid of some transitive dependencies.