[pull] master from monkeytypegame:master#852
Merged
pull[bot] merged 6 commits intoUncodedtech:masterfrom Apr 2, 2026
Merged
Conversation
…#7758) ### Description Only call `setfpsLimit` when the user enters a new value for the fps limit setting. This is so the user won't get the "FPS limit updated" notification when they don't change the limit (e.g. clicking on the `native` button multiple times, entering a custom limit and holding `Enter`).
…races (@Leonabcd123) (#7754) ### Description First signal's first frame in `frames` array in https://github.com/monkeytypegame/monkeytype/blob/82bf09564c2fdaaeb8273c638ec1eb7e7e6eb3cb/frontend/src/ts/dev/signal-tracker.ts#L35 Chromium: `at getCallerInfo (http://localhost:3000/ts/dev/signal-tracker.ts?t=1774961577350:5:16)` Firefox: `DEV.hooks.afterRegisterGraph@http://localhost:3000/ts/dev/signal-tracker.ts?t=1774961577350:84:34` They both should be referring to `getCallerInfo`, but only chromium does, because firefox slices off that frame in the code linked above, while chromium slices off the string "Error". Doesn't really matter because the `getCallerInfo` frame will be skipped anyways, but this should still be done to make behavior more consistent across different browsers.
…#7723) ### Description Rectified the error of loading the challenges through url. 1. delayed the loading of the challenges from url. 2. updated the notifications. (as it was notifying both in controller and in the handler) ### Checks - [x] Check if any open issues are related to this PR; if so, be sure to tag them below. - [x] Make sure the PR title follows the Conventional Commits standard. (https://www.conventionalcommits.org for more info) - [x] Make sure to include your GitHub username prefixed with @ inside parentheses at the end of the PR title. Closes #7704 Reference Image <img width="1600" height="707" alt="image" src="https://github.com/user-attachments/assets/9b1f87c7-ece2-4530-a4f1-4134d2cd57e9" />
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )