Conversation
added 10 commits
January 22, 2025 12:55
pop var computations restore def cred rm token update core module
iferencik
had a problem deploying
to
az container registry
GitHub Actions
Failure
iferencik
temporarily deployed
to
github container registry
GitHub Actions
Inactive
JinIgarashi
reviewed
Jan 31, 2025
JinIgarashi
suggested changes
Jan 31, 2025
Contributor
JinIgarashi
left a comment
JinIgarashi
left a comment
There was a problem hiding this comment.
@iferencik overall, the PR looks good.
Most of my comments are related to revert az string to azure. az is not understandable, and I prefer using azure explicitly for comments and console messages.
I would like to request to merge your new logic of zst.py into current ZonalStats.py
iferencik
temporarily deployed
to
github container registry
GitHub Actions
Inactive
iferencik
temporarily deployed
to
azure container registry
GitHub Actions
Inactive
removed _with_session functions
iferencik
temporarily deployed
to
azure container registry
GitHub Actions
Inactive
iferencik
temporarily deployed
to
github container registry
GitHub Actions
Inactive
change az to azure
iferencik
temporarily deployed
to
azure container registry
GitHub Actions
Inactive
iferencik
temporarily deployed
to
github container registry
GitHub Actions
Inactive
replace az with azure in docstrings
iferencik
temporarily deployed
to
azure container registry
GitHub Actions
Inactive
iferencik
temporarily deployed
to
github container registry
GitHub Actions
Inactive
replace az with azure in docstrings
iferencik
temporarily deployed
to
github container registry
GitHub Actions
Inactive
iferencik
temporarily deployed
to
azure container registry
GitHub Actions
Inactive
replace az with azure in docstrings
iferencik
temporarily deployed
to
azure container registry
GitHub Actions
Inactive
iferencik
temporarily deployed
to
github container registry
GitHub Actions
Inactive
iferencik
temporarily deployed
to
azure container registry
GitHub Actions
Inactive
iferencik
temporarily deployed
to
github container registry
GitHub Actions
Inactive
JinIgarashi
approved these changes
Jan 31, 2025
iferencik
added a commit
that referenced
this pull request
Apr 10, 2025
* added pop variables in json format * pop variables * cove abstract classes and vars * added azure uplaod/download functions * variable download * add var/component functions to session * func zonal stats and vector resolve * gdalcalc test * use vsimem VRT in zstat pop var computations restore def cred rm token update core module * Update ci.yml * Update blobstorage.py removed _with_session functions * Update __init__.py change az to azure * Update worldpop.py replace az with azure in docstrings * Update initialize.py replace az with azure in docstrings * Update session.py replace az with azure in docstrings * remove unused import and clean up a bit --------- Co-authored-by: Ioan Ferencik <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This request brings class based design to rapida
azure blob upload/download closes #71
session as singleton
SurgeVariable