Conversation
Thuhaa
temporarily deployed
to
github container registry
GitHub Actions
Inactive
Thuhaa
temporarily deployed
to
azure container registry
GitHub Actions
Inactive
This was
linked to
issues
Jan 20, 2025
Thuhaa
changed the title
Thuhaa
temporarily deployed
to
github container registry
GitHub Actions
Inactive
Thuhaa
temporarily deployed
to
azure container registry
GitHub Actions
Inactive
4 tasks
JinIgarashi
reviewed
Jan 21, 2025
Thuhaa
temporarily deployed
to
github container registry
GitHub Actions
Inactive
Thuhaa
temporarily deployed
to
azure container registry
GitHub Actions
Inactive
Thuhaa
temporarily deployed
to
github container registry
GitHub Actions
Inactive
Thuhaa
temporarily deployed
to
azure container registry
GitHub Actions
Inactive
JinIgarashi
approved these changes
Jan 21, 2025
Contributor
There was a problem hiding this comment.
@Thuhaa looks good. is AzureBlobStorageManager class (blob_storage.py) no longer used anywhere? if so, you can delete it. also delete AZURE_STORAGE_CONNECTION_STRING variable from .env.example if no need anymore
Thuhaa
temporarily deployed
to
github container registry
GitHub Actions
Inactive
Thuhaa
temporarily deployed
to
azure container registry
GitHub Actions
Inactive
Thuhaa
temporarily deployed
to
github container registry
GitHub Actions
Inactive
Thuhaa
temporarily deployed
to
azure container registry
GitHub Actions
Inactive
4 tasks
iferencik
pushed a commit
that referenced
this pull request
Apr 10, 2025
* refactor: use session class in worldpop.py file * remove hardcoded container name to use one in config * refactor: use context manager to access blob_service_client * cleanup .env.example and remove azure module
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following implementation is done in this PR. Checked tasks means the task is completed.
AzureBlobStorageManagerclass to useSessionin theworldpop.pyWhen this is done, issues #114 will be closed