fix(ts-interface-generator): properly type getters for properties of type object and function #565
Open
fix(ts-interface-generator): properly type getters for properties of type object and function #565
object and function #565Conversation
So that a definition of
`someFunc: { type: "function", group: "Behavior", defaultValue: null }`
correctly generates :
`getSomeFunc(): Function | null;`
wridgeu
changed the title
object and function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For types like
objectorfunctionthe default value was/is not respected when generating accessors. The getter would/is wrongly typed when no callbacks/fns are provided to control properties.So that a definition of
someFunc: { type: "function", group: "Behavior", defaultValue: null }correctly generates :
getSomeFunc(): Function | null;instead of:
getSomeFunc(): FunctionI'm not that deep in the code base but have noticed that not all types have tests (though, I patched this locally in a project of mine so ... it works) and also that this change could maybe live somewhere in
function generateMethods. Cases like this one, albeit a rather unusual one, would not be covered today (probably rather a wrong definition in UI5 itself and thus user/dev error more more than anything else).Some more examples of similar definitions within UI5 ...