User/dillonsd/AuxBmsWorks #193
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should double check DMA, ADC and SPI settings
Only difficulty is that for CMSIS v2, CubeMx does not support memory pools so we are assuming we'll be fine with just queues. Worst case, we'll use pvMalloc and pvFree for dynamic allocation.
…ine-and-initialize-variables User/embedded/sft 167 define and initialize variables
Created functions, tasks, and unit tests relating to contactor control.
…ate-functions-and-unit-tests-relating-to-contactor-control User/embedded/sft 175 create functions and unit tests relating to contactor control
…peripheral-configs-and-initializations CAN Interrupt and Filter Config
…ate-functions-and-unit-test-relating-to-orion-work User/embedded/sft 190 create functions and unit test relating to orion work
…200-Create-functions-relating-to-CAN-Tx-work
…ate-functions-relating-to-CAN-Tx-work User/embedded/sft 200 create functions relating to can tx work
…CSolarCarTeam/Epsilon-Embedded-Software into user/embedded/SFT-202-Creating-functions-and-unit-tests-relating-to-aux-voltage-reading-work
…ating-functions-and-unit-tests-relating-to-aux-voltage-reading-work User/embedded/sft 202 creating functions and unit tests relating to aux voltage reading work
…ating-functions-and-unit-tests-relating-to-aux-voltage-reading-work Adding unit tests
Implemented stack overflow hook, and malloc failed hook, and error handler
…lement-error-handling SFT 203. Implementing error handling
…lement-memory-debug-tasks SFT 204. Implemented memory debug task
…ean-up Removed magic numbers. Added unit tests to travis.
…t-fixes OrionInterfaceTest final fixes
…he old code we take in multiple adc reads and check if they're stable before we actually use that for calculation. Wrote code for that
… queue, added function to check if orion is happy before setting the common contactor in startup task, change to only execute the orionInterface function if orion is happy before startup happens, changed orion interface to only disconnect contactor once start up is done which we set the variable in discharge contactor gatekeeper because the contactorStatusUpdate function is not running. This is very ghetto and will need to be fixed however at this point the AuxBMS should be useable
…am/Epsilon-Embedded-Software into user/Dillonsd/AuxBMSTesting
…ick not SysTick as delay func and macros are based on TaskTicks
JessieG123
reviewed
May 21, 2022
Contributor
JessieG123
left a comment
JessieG123
left a comment
There was a problem hiding this comment.
We will not be merging all 77 commits, will be picking the commits to merge.
| @@ -0,0 +1,207 @@ | |||
| /** | |||
Contributor
There was a problem hiding this comment.
Why is this file generated for EpsilonAuxBMS? Dillonsd Trying SPI global IRQ disabled
| @@ -16,180 +16,185 @@ static const char* CMockString_isContactorError = "isContactorError"; | |||
|
|
|||
Contributor
There was a problem hiding this comment.
Seems like an astyle thing, check if we need this. Since it's in EpsilonAuxBMS.
JessieG123
suggested changes
May 21, 2022
| uint8_t isCurrentLow(uint8_t numContactorsClosed); | ||
|
|
||
| int isCurrentStable(uint32_t senses[]); | ||
| uint32_t readCurrentThroughContactors(void); No newline at end of file |
| //vTaskList(pcWriteBuffer); | ||
|
|
||
| vPortFree(pcWriteBuffer); | ||
| } No newline at end of file |
| orionHappy |= (!orionDischargeEnableSense && !orionChargeEnableSense); | ||
|
|
||
| return orionHappy; //if this is 1 it means that orion is NOT happy | ||
| } No newline at end of file |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Everything