Open
Conversation
burtonjong
requested changes
Nov 2, 2025
Member
burtonjong
left a comment
burtonjong
left a comment
There was a problem hiding this comment.
Didn't feel like using typescript?? lol
| import React from "react"; | ||
|
|
||
| function App() { | ||
| const [userData, setUserData] = React.useState([]) |
Member
There was a problem hiding this comment.
You don't have to do React.useState you can instead just import useState directly.
import { useState, useEffect } from "react";
Comment on lines
13
to
16
| function fullNames (searchValue) { | ||
| const names = userData.map((firstNames) => (firstNames.name.first.toLowerCase())) | ||
| const target = document.getElementsByClassName("name"); | ||
| if (names.indexOf(searchValue) !== -1) target[names.indexOf(searchValue)].scrollIntoView({ behavior: "smooth", block: "start" }) |
Member
There was a problem hiding this comment.
The search shouldnt scroll to the user, rather it should filter and only show the user that has been searched. For example, if there was a name of John, when I type jo, Only names starting with jo should show.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.