Skip to content

Conversation

@marghe-molaro
Copy link
Collaborator

This PR updates previous PR draft #1468

Now includes changes in the mother_and_newborn_info dataframe.

…th, label what is only used for ddebugging and will be later removed
…ible to all modules. For now add person_ID to the dict of info printed as the outer dictionary key logging seems to have a problem.
…lysis file now collects all relevant info and prints them
…rected analysis file such as for small number of cases where the DALYs are not explicitly resolved the average DALYs are still computed correctly [skip ci]
@marghe-molaro
Copy link
Collaborator Author

A few suggestions below...

Looking at the logs, I don't know how common is the following scenario: same individual, repeated same event on the same dat i.e. you would get a number of entries that were potentially of a different execution of the same event. If so, you could add an incrementing counter that gets logged as an identifier to group the entries in the EAV table. Might not be necessary if this doesn't happen.

Thanks @tamuri, I have now included a sim-wide counter of events being ran that is appended as a unique identifier to the event name when logged (this doesn't apply to birth events, which I think we can safely assume only occur once per individual!)

I have additionally included a similar counter - which in this case is however reset for each event - which tracks the instance of consumable requests within that HSI, ensuring that if multiple consumable calls occur within the same HSI_Event these can be logged separately.

@tamuri
Copy link
Collaborator

tamuri commented Jan 9, 2026

I have now included a sim-wide counter of events being ran that is appended as a unique identifier to the event name when logged

Looks good, though better to put the identifier as a new, separate, column in the row, which would allow the use of the event name for any purpose.

Comment on lines +79 to +80
output = parse_log_file(sim.log_filepath, level=logging.DEBUG)
output_chains = parse_log_file(sim.log_filepath, level=logging.INFO)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicated!

Copy link
Collaborator

@tamuri tamuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good to merge!

@tamuri
Copy link
Collaborator

tamuri commented Jan 12, 2026

Some checks failing

@tamuri tamuri merged commit 842f7f6 into master Jan 13, 2026
67 checks passed
@tamuri tamuri deleted the molaro/harvest-training-data-including-mni branch January 13, 2026 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants