Removed custom-webfinger flag

[mike182uk]

ref https://linear.app/ghost/issue/AP-963

Removed custom-webfinger flag that was being used to validate custom webfinger solution in prod for www based hosts

[coderabbitai]

Walkthrough

The changes remove the use of the feature flag 'custom-webfinger' and its associated FlagService dependency from the application's custom webfinger handler. In the application initialization, the FlagService is now instantiated without any feature flags, and the webfinger route handler is created without passing the flagService instance. Within the webfinger handler module, the function signature for createWebFingerHandler no longer accepts a flagService parameter, and all conditional logic based on the 'custom-webfinger' feature flag has been deleted. As a result, the custom webfinger logic is now always executed for acct: resources. Correspondingly, all references to FlagService have been removed from the unit tests for the webfinger handler, including imports, setup, and function calls.

Possibly related PRs

• Added custom webfinger handler #520: Removes the feature flag check and the flagService dependency from the custom webfinger handler, directly modifying the same handler and its integration as in this PR.
• Implemented basic flag system #522: Introduces the initial implementation of the FlagService and its integration into the app; this PR modifies code that directly depended on the feature flag system established here.

Tip

⚡💬 Agentic Chat (Pro Plan, General Availability)

• We're introducing multi-step agentic chat in review comments and issue comments, within and outside of PR's. This feature enhances review and issue discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments and add commits to existing pull requests.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6c012d7 and e8606a7.

📒 Files selected for processing (3)

• src/app.ts (2 hunks)
• src/http/handler/webfinger.ts (0 hunks)
• src/http/handler/webfinger.unit.test.ts (0 hunks)

💤 Files with no reviewable changes (2)

• src/http/handler/webfinger.unit.test.ts
• src/http/handler/webfinger.ts

🚧 Files skipped from review as they are similar to previous changes (1)

• src/app.ts

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: Build, Test and Push

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.