Skip to content

fix: respond to webhooks immediately to prevent GitHub retries #319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
worlddriven merged 1 commit into from
Dec 3, 2025
Merged

fix: respond to webhooks immediately to prevent GitHub retries #319

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
69 changes: 40 additions & 29 deletions src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -520,46 +520,57 @@ async function startServer() {
});

// GitHub webhook endpoint
app.post('/github', async function (req, res) {
// Respond immediately to avoid GitHub's 10-second timeout and retries
app.post('/github', function (req, res) {
const eventType = req.headers['x-github-event'];
const deliveryId = req.headers['x-github-delivery'];
const data = req.body;

console.log(`GitHub webhook received: ${eventType}`);
console.log(
`GitHub webhook received: ${eventType} (delivery: ${deliveryId})`
);

try {
let result;
// Respond immediately to prevent GitHub timeout/retry
res.json({ info: 'Webhook received, processing asynchronously' });

switch (eventType) {
case 'installation':
result = await handleInstallationWebhook(data);
break;
// Process webhook asynchronously
(async () => {
try {
switch (eventType) {
case 'installation':
await handleInstallationWebhook(data);
break;

case 'installation_repositories':
result = await handleInstallationRepositoriesWebhook(data);
break;
case 'installation_repositories':
await handleInstallationRepositoriesWebhook(data);
break;

case 'pull_request':
result = await handlePullRequestWebhook(data);
break;
case 'pull_request':
await handlePullRequestWebhook(data);
break;

case 'pull_request_review':
result = await handlePullRequestReviewWebhook(data);
break;
case 'pull_request_review':
await handlePullRequestReviewWebhook(data);
break;

case 'push':
result = await handlePushWebhook(data);
break;
case 'push':
await handlePushWebhook(data);
break;

default:
console.log(`Unhandled webhook event: ${eventType}`);
result = { info: `Event ${eventType} not handled` };
}
default:
console.log(`Unhandled webhook event: ${eventType}`);
}

res.json(result);
} catch (error) {
console.error('Webhook processing error:', error);
res.status(500).json({ error: 'Webhook processing failed' });
}
console.log(
`Webhook ${eventType} (${deliveryId}) processed successfully`
);
} catch (error) {
console.error(
`Webhook ${eventType} (${deliveryId}) processing error:`,
error
);
}
})();
});

// Handle HTML serving - different for production vs development
Expand Down