fix: filter push events by PR branch to prevent timer reset #318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a PR was merged to master, the push event affected the merge timer calculation for all other open PRs. This happened because getDates() was fetching all repository events and using the most recent PushEvent regardless of which branch it targeted. Now the code filters push events to only include those where payload.ref matches the PR's head branch (refs/heads/<branch-name>), preventing merges to master or other branches from resetting unrelated PR timers. Closes #752
Contributor
🤖 Worlddriven Status📊 Live Status Dashboard🗓️ Merge Date: 2025-12-05 at 19:12:26 UTC (today) 🎯 Want to influence when this merges?Your review matters! As a contributor to this project, your voice helps determine the merge timeline. How to review:
Your options:
💡 Pro tip: The more contributors who agree, the faster this gets merged! 📊 View detailed stats on the dashboard 📋 Recent Activity• 2025-11-30, 11:35:47 - Pull request opened This comment is automatically updated by worlddriven |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
getDates()which fetched all repository events and used the most recentPushEventregardless of branchpayload.refto only include pushes to the PR's specific head branchRoot Cause
When processing push events in
pullRequest.js, the code was:pull.head.repo.events_url(all repository events)PushEventwithout filtering by branchdates.maxfor timer calculationThis meant when PR #748 was merged (pushing to master), that
PushEventbecame the most recent for ALL open PRs, resetting their timers.Fix
Added a filter to only consider push events where
current.payload.ref === refs/heads/${pull.head.ref}Test plan