fix: webhook handler GitHubClient instantiation #313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The webhook handler was passing installationId directly to getPullRequestData() instead of creating a GitHubClient instance. This caused webhooks to fail with "githubClient.getPullRequest is not a function" error. Updated processPullRequest() to: - Import Auth and GitHubClient classes - Create Auth instance with owner/repo - Create GitHubClient instance with Auth - Pass GitHubClient to getPullRequestData() This matches the working pattern in pullRequestProcessor.js. Closes #312
Contributor
🤖 Worlddriven Status📊 Live Status Dashboard🗓️ Merge Date: 2025-11-17 at 08:28:49 UTC (today) 🎯 Want to influence when this merges?Your review matters! As a contributor to this project, your voice helps determine the merge timeline. How to review:
Your options:
💡 Pro tip: The more contributors who agree, the faster this gets merged! 📊 View detailed stats on the dashboard 📋 Recent Activity• 2025-11-17, 08:51:45 - Pull request merged by worlddriven ✅ This comment is automatically updated by worlddriven |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes webhook processing failure caused by incorrect parameter passing to
getPullRequestData().Problem
The webhook handler was passing
installationIddirectly togetPullRequestData()instead of creating aGitHubClientinstance, causing webhooks to fail with:Solution
Updated
processPullRequest()insrc/helpers/webhookHandler.jsto:Authinstance with owner/repoGitHubClientinstance with AuthGitHubClienttogetPullRequestData()This matches the working pattern already used in
pullRequestProcessor.js.Impact
Testing
pullRequestProcessor.jsCloses #312