Skip to content

Conversation

@vdemay
Copy link

@vdemay vdemay commented Nov 30, 2020

merge better error handling to pyppeteer version

@vdemay
Copy link
Author

vdemay commented Nov 30, 2020

Note : On my side, i'm using pyppeteer version because base version leads to tons of issue during installation (on Linux). Why do you switch from Pyppeteer to playwright. It seems it leads to several issues such as multithread issues, installation issues and so on ?
Furthermore, It's very hard to maintain 2 forks at a time. Merging stuff becomes more and more difficult

@vdemay vdemay mentioned this pull request Nov 30, 2020
@davidteather
Copy link

Why do you switch from Pyppeteer to playwright.

Pyppeteer didn't support synchronous calls. The script launches a new browser each method call because of it, w/ playwright it allows for a persistent browser across the entire TikTokApi class making it more efficient. Added selenium support to the main once bc that's got synchronous support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants