Merged
Conversation
rustybee42
force-pushed
the
rb/fix-v7-import
branch
from
c8a92fd to
1c61240
Compare
iamjoemccormick
requested changes
Mar 11, 2026
Member
iamjoemccormick
left a comment
iamjoemccormick
left a comment
There was a problem hiding this comment.
Presuming one doesn't already exist, should we also add an integration test that exercises the full end-to-end v7 import? A fixture (v7 mgmtd data) that includes all importable data types (nodes, targets, buddy groups, pools, etc.) would complement the existing unit tests without needing to fully re-verify the imported values, just that the import succeeds without constraint errors and maybe sanity check node, target, quota, etc. counts match up.
rustybee42
force-pushed
the
rb/fix-v7-import
branch
2 times, most recently
from
2f0b281 to
03bdcd2
Compare
iamjoemccormick
previously approved these changes
Mar 12, 2026
Member
iamjoemccormick
left a comment
iamjoemccormick
left a comment
There was a problem hiding this comment.
LGTM - though I would still recommend we find a way to increase our test coverage around v7 imports.
This let the import fail. We now call target::insert directly for meta nodes which does not insert into root_inode. Also remove target::insert_meta
rustybee42
force-pushed
the
rb/fix-v7-import
branch
from
03bdcd2 to
c0b851d
Compare
rustybee42
force-pushed
the
rb/fix-v7-import
branch
from
38eaad8 to
ca06f84
Compare
iamjoemccormick
previously approved these changes
Mar 17, 2026
Uses a v7 management data folder created with 7.4
rustybee42
force-pushed
the
rb/fix-v7-import
branch
from
ca06f84 to
449be6b
Compare
iamjoemccormick
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes v7 import, which broke on 8.3 due to a double insert into the
root_inodetable.