Require correct libc version on built packages and update license#56
Merged
rustybee42 merged 4 commits intomainfrom Mar 16, 2026
Merged
Require correct libc version on built packages and update license#56rustybee42 merged 4 commits intomainfrom
rustybee42 merged 4 commits intomainfrom
Conversation
rustybee42
force-pushed
the
rb/package-build-libc-requirement
branch
from
6b25e86 to
87a2f61
Compare
Collaborator
Author
|
Check if the new include field can be used to dynamically inject the settings into Edit: Done |
rustybee42
force-pushed
the
rb/package-build-libc-requirement
branch
from
87a2f61 to
d19bb0a
Compare
Collaborator
Author
No, that doesn't really work or is at least not less complicated. Not doing that for now. |
iamjoemccormick
requested changes
Mar 6, 2026
iamjoemccormick
requested changes
Mar 11, 2026
rustybee42
force-pushed
the
rb/package-build-libc-requirement
branch
from
3602233 to
020e455
Compare
iamjoemccormick
previously approved these changes
Mar 13, 2026
Done by patching the Cargo.toml file temporarily (cargo deb does not provide a command line option to set that). Since we usually don't want to make automatic changes to the source code, we store the original file and restore it after the script completes (even on error).
Before the build would just silently ignore GLIBC_VERSION and build normally (without zigbuild).
rustybee42
force-pushed
the
rb/package-build-libc-requirement
branch
from
33c3360 to
4d125fc
Compare
Enabled new "fallible_uint" feature on rusqlite which is now required due to our heavy use of u64 as sql parameters. Fix clippy complaints.
rustybee42
force-pushed
the
rb/package-build-libc-requirement
branch
from
4d125fc to
175b66e
Compare
iamjoemccormick
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also Update Rust and dependencies.
Closes #7