Potential fix for code scanning alert no. 1: Arbitrary file access during archive extraction ("Zip Slip") #56
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/TheWorldAvatar/stack/security/code-scanning/1
To fix the issue, the code must validate the paths extracted from the tar archive to ensure they do not lead to directory traversal. This can be achieved by normalizing the paths and verifying that they remain within the intended target directory. Specifically:
Path.normalize()orFile.getCanonicalFile()to normalize the paths.targetDir).The fix will involve modifying the
retrieveFilesmethod to validatetarArchiveEntry.getName()before adding it to thefilesmap. Additionally, thecopyTomethod will indirectly benefit from this validation since it uses the output ofretrieveFiles.Suggested fixes powered by Copilot Autofix. Review carefully before merging.