XInputProKeyboard: amend location of touchStrip #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bytes representing the XInput keytar touch strip don't seem to be in the correct position, and as a result nothing is reported when touching the slider.
Sources for fix: XInput Keytar PlasticBand Documentation, and PS3ProKeyboard.cs (which this PR now matches).
It seems like this hasn't really been a bug before the shotgun backend, as XInput on Windows doesn't include these bytes. It might be a good idea to test Windows anyway, as I'm not sure what would happen if it if tries to read bytes out of range.
Thanks!