Use environment variable $ARCH when available#13
Open
knarfS wants to merge 1 commit intoTheAssassin:masterfrom
Open
Use environment variable $ARCH when available#13knarfS wants to merge 1 commit intoTheAssassin:masterfrom
knarfS wants to merge 1 commit intoTheAssassin:masterfrom
Conversation
Merged
TheAssassin
requested changes
Dec 23, 2024
Owner
TheAssassin
left a comment
TheAssassin
left a comment
There was a problem hiding this comment.
I'm not sure this is a good idea, but there should at least be a warning.
Please also resolve the conflicts.
|
|
||
| arch = self._config.get("arch", platform.machine()) | ||
| if "ARCH" in os.environ: | ||
| arch = os.environ["ARCH"] |
Owner
There was a problem hiding this comment.
You should provide a warning that signalizes to the user that data from the environment was taken into account.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the environment variable
$ARCHis already set, it is applied and the build script doesn't need to figure out the architecture by itself. This is needed for 32bit containers in an 64bit environment and is now also in line with the linuxdeploy behaviour.