Kkostial/small refactorings #205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: karo <[email protected]>
…e conversion Signed-off-by: karo <[email protected]>
Signed-off-by: karo <[email protected]>
Removed `Duration`, `InvariantBase64Equals`, `NullDuration`, and related helper functions from internal packages as they are no longer used. Signed-off-by: karo <[email protected]>
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request performs code cleanup by removing unused utility functions and helper packages while making minor improvements to maintainability. The changes reduce code complexity without affecting functionality.
Changes:
- Removed unused utility functions from
utils/security.goand deleted the entireutils/base64.gofile - Deleted unused custom duration and PostgreSQL interval helper packages
- Fixed unnecessary type conversion in password rule deserialization
- Registered missing handler for patching virtual servers in the mediator
- Added IDE suppression comments for exported functions that are internal
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| utils/security.go | Removed unused GenerateCodeFromBytes and ImportPrivateKey functions while preserving the actively used GetSecureRandomBytes |
| utils/base64.go | Deleted entire file containing InvariantBase64Equals function that is no longer used anywhere in the codebase |
| internal/jsonTypes/Duration.go | Deleted custom Duration JSON marshaler/unmarshaler that is no longer used |
| internal/database/postgres/helpers/interval.go | Deleted PostgreSQL interval parsing helpers that are no longer needed |
| internal/password/password.go | Removed unnecessary []byte() conversion since passwordRule.Details() already returns []byte |
| internal/setup/mediator.go | Added missing registration for HandlePatchVirtualServer command handler |
| internal/services/audit/audit.go | Added IDE suppression comment for exported NewConsoleAuditLogger function |
| internal/jobs/JobRunner.go | Added IDE suppression comment for exported WithTimeout function |
| tests/integration/serviceuser_flow_test.go | Added IDE suppression comment for test constants |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes several utility and helper packages related to duration handling, base64 encoding, and security, as well as refactors some code to improve maintainability and clarity. The most important changes are the removal of custom duration and base64 helpers, the elimination of unused security-related code, and small improvements to job, audit, and password modules.
Utility and helper package removals
internal/database/postgres/helpers/interval.gofile, which contained custom functions for handling PostgreSQL interval types and conversions.internal/jsonTypes/Duration.gofile, which provided a custom JSON marshaler/unmarshaler for durations.utils/base64.gofile, which implemented invariant base64 comparison and normalization helpers.utils/security.go, including code generation and key import helpers.Minor refactoring and improvements
internal/password/password.go.golandinspection comments to suppress IDE warnings for unused exported functions and constants in job runner, audit, and integration test files. [1] [2] [3]