Conversation
Signed-off-by: Jack Luar <39641663+luarss@users.noreply.github.com>
- Replace doc_check_test() with py_test() in all 24 module BUILD files so test failures propagate via exit code, not log diff - Delete 24 *_readme_msgs_check.ok snapshot files -> replace with unittest assertions Signed-off-by: Jack Luar <39641663+luarss@users.noreply.github.com>
|
clang-tidy review says "All clean, LGTM! 👍" |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the documentation check tests by replacing module-specific scripts and expected output files with a shared Python script accessed via symlinks. Corresponding Bazel BUILD files are updated to use standard py_test targets. Feedback includes updating the documentation to reflect the removal of .ok files and the transition to py_test, as well as avoiding the use of os.getcwd() for test output directories to ensure robustness within the Bazel environment.
os.environ.get("TEST_TMPDIR") or tempfile.mkdtemp()
- fix buildifier lints (tags after deps)
- fix docs
Signed-off-by: Jack Luar <39641663+luarss@users.noreply.github.com>
|
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: Jack Luar <39641663+luarss@users.noreply.github.com>
|
clang-tidy review says "All clean, LGTM! 👍" |
oharboe
left a comment
oharboe
left a comment
There was a problem hiding this comment.
@maliberty there has to be a bazel idiomatic way to do this to avoid the symlinks, but we need to keep the non-bazel testing flow, I suppose.
The docker image still has the non-bazel build, the non-bazel testing is required.
2 participants
Summary
.okfilesType of Change
Impact
Maintains doc tests behavior
Verification
./etc/Build.sh).Related Issues
n/a