Skip to content

Conversation

@luis201420
Copy link
Contributor

Fixes #9042
Add the next flags for repair_antennas command:

  • allow_congestion: Allow congestion when rerouting repaired nets.
  • jumper_only: Use only jumpers to repair nets.
  • diode_only: Use only diodes to repair nets.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces new options for the repair_antennas command, allowing users to specify repair strategies using jumpers only or diodes only, and to allow congestion during rerouting. The changes are consistently applied across the C++, SWIG, and Tcl files. The logic correctly handles the new flags, including a check for mutually exclusive options. My review identified a minor stylistic issue regarding indentation in the Tcl script.

Comment on lines +245 to +247
[-jumper_only] \
[-diode_only] \
[-allow_congestion]}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The indentation for the new flags uses tabs, while the existing code in this block uses spaces for alignment. For consistency with the surrounding code, please use spaces instead of tabs.

                                         [-jumper_only] \
                                         [-diode_only] \
                                         [-allow_congestion]}

Copy link
Contributor

@eder-matheus eder-matheus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address clang-format and also add some unit tests for the new flags.

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

repair_antennas: additional options

2 participants