-
Notifications
You must be signed in to change notification settings - Fork 755
GRT: add options for repair antennas #9181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
GRT: add options for repair antennas #9181
Conversation
…tennas Signed-off-by: luis201420 <[email protected]>
Signed-off-by: luis201420 <[email protected]>
…tennas Signed-off-by: luis201420 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces new options for the repair_antennas command, allowing users to specify repair strategies using jumpers only or diodes only, and to allow congestion during rerouting. The changes are consistently applied across the C++, SWIG, and Tcl files. The logic correctly handles the new flags, including a check for mutually exclusive options. My review identified a minor stylistic issue regarding indentation in the Tcl script.
| [-jumper_only] \ | ||
| [-diode_only] \ | ||
| [-allow_congestion]} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
eder-matheus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address clang-format and also add some unit tests for the new flags.
|
clang-tidy review says "All clean, LGTM! 👍" |
Fixes #9042
Add the next flags for
repair_antennascommand:allow_congestion: Allow congestion when rerouting repaired nets.jumper_only: Use only jumpers to repair nets.diode_only: Use only diodes to repair nets.