Break out Tcl readline set-up into separate file.#10057
Break out Tcl readline set-up into separate file.#10057maliberty merged 1 commit intoThe-OpenROAD-Project:masterfrom
Conversation
It became a bit bulky in the Main.cc. Signed-off-by: Henner Zeller <h.zeller@acm.org>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the tclreadline initialization logic by moving it from Main.cc into a dedicated tcl_readline_setup library, with corresponding updates to Bazel and CMake build systems. Feedback focuses on addressing a regression in error handling where initialization failures no longer terminate the application, ensuring error messages are sent to stderr, and improving code maintainability by cleaning up includes and using helper functions for Tcl command evaluation.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
clang-tidy has the usual issue with tcl includes, rest looks good. |
|
Once we have this in, we can use a simple function call in the submodule opensta build to also get readline support for free. |
sta can also be built standalone. How will this work? Normally sta has no dependency on OR |
|
Right now, for the purpose of bazel, openSTA can only be built when it is part of a submodule within OpenROAD. OpenSTA does not have its own MODULE.bazel for instance., so the BUILD file it has only works within OpenROAD. |
|
I don't think we should assume that into the future. |
|
once we want to build opensta standalone with bazel, we can revisit |
2 participants
It became a bit bulky in the Main.cc.