flow: platforms: {gf180,sky130}: allow PDK path overrides via weak assignment#4146
Merged
maliberty merged 2 commits intoThe-OpenROAD-Project:masterfrom Apr 14, 2026
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the configuration files for gf180, sky130hd, and sky130hs platforms to use weak assignments (?=) for various variables, enabling easier user overrides. However, several review comments point out a significant issue: using weak assignments for GDS_FILES and LIB_FILES while including ADDITIONAL_GDS or ADDITIONAL_LIBS in the same line causes those additional variables to be lost if the main variable is overridden. The feedback suggests separating the default path assignment from the addition of user-specified files to ensure both can coexist correctly.
Convert TECH_LEF, GDS_FILES, and all timing corner variables (BC/WC/TC lib files, temperatures, voltages) from strong (`=`) to weak (`?=`) assignment so users can substitute a custom PDK version without modifying ORFS-provided files. Signed-off-by: Daniel Schultz <dnltz@aesc-silicon.de>
Convert TECH_LEF, SC_LEF, LIB_FILES, and GDS_FILES from strong (`=`) to weak (`?=`) assignment so users can substitute a custom PDK version by setting these variables before including the platform config, without modifying ORFS-provided files. Signed-off-by: Daniel Schultz <dnltz@aesc-silicon.de>
dnltz
force-pushed
the
WIP/dnltz/platform-weak-assignment
branch
from
3532a90 to
f9ebc9a
Compare
maliberty
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert TECH_LEF, SC_LEF, LIB_FILES, and GDS_FILES from strong (
=) to weak (?=) assignment so users can substitute a custom PDK version by setting these variables before including the platform config, without modifying ORFS-provided files.