Skip to content

WDT32: Add reset to wden_p to fix WDOV X-propagation after reset #4142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ashnaaseth2325-oss wants to merge 2 commits into
base: master
Choose a base branch
from
+8 −6
Open

WDT32: Add reset to wden_p to fix WDOV X-propagation after reset #4142

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9836c6b
rtl: fix missing reset on wden_p in WDT32
ashnaaseth2325-oss Apr 13, 2026
ddea65c
WDT32: apply reset fix to duplicated hierarchical IP module
ashnaaseth2325-oss Apr 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .gitmodules
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
url = ../../The-OpenROAD-Project/yosys.git
[submodule "tools/OpenROAD"]
path = tools/OpenROAD
url = ../OpenROAD.git
url = https://github.com/The-OpenROAD-Project/OpenROAD.git
[submodule "tools/yosys-slang"]
path = tools/yosys-slang
url = https://github.com/povik/yosys-slang.git
Expand Down
5 changes: 3 additions & 2 deletions flow/designs/src/chameleon/IPs/WDT32.v
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,9 @@ module WDT32 (
end

reg wden_p;
always @(posedge clk)
wden_p <= WDEN;
always @(posedge clk or posedge rst)
if (rst) wden_p <= 1'b0;
else wden_p <= WDEN;
Comment on lines +43 to +45
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The addition of the asynchronous reset to wden_p correctly addresses the X-propagation issue during simulation. However, the same IP module is duplicated at flow/designs/src/chameleon_hier/rtl/IPs/WDT32.v and remains unpatched in this pull request. To ensure consistency across the repository and prevent simulation/synthesis mismatches in designs using the hierarchical path, this fix should be applied to that file as well.


always @(posedge clk or posedge rst)
begin
Expand Down
5 changes: 3 additions & 2 deletions flow/designs/src/chameleon_hier/rtl/IPs/WDT32.v
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,9 @@ module WDT32 (
end

reg wden_p;
always @(posedge clk)
wden_p <= WDEN;
always @(posedge clk or posedge rst)
if (rst) wden_p <= 1'b0;
else wden_p <= WDEN;

always @(posedge clk or posedge rst)
begin
Expand Down
2 changes: 1 addition & 1 deletion tools/OpenROAD
Open in desktop
Submodule OpenROAD updated 31 files
+4 −1 src/CMakeLists.txt
+0 −4 src/OpenRoad.i
+9 −33 src/ant/src/AntennaChecker.cc
+0 −4 src/est/src/EstimateParasitics.i
+6 −16 src/grt/src/fastroute/src/utility.cpp
+3 −3 src/gui/src/staGuiInterface.cpp
+0 −4 src/ifp/src/InitFloorplan.i
+2 −3 src/mpl/src/SACoreSoftMacro.cpp
+0 −4 src/odb/include/odb/db.h
+1 −5 src/odb/src/db/dbDatabase.h
+0 −15 src/odb/src/db/dbTechLayer.cpp
+7 −41 src/odb/src/db/dbTechLayerAntennaRule.cpp
+5 −3 src/odb/src/db/dbTechLayerAntennaRule.h
+22 −85 src/odb/src/lefin/AntennaGateParser.cpp
+3 −2 src/odb/src/lefin/lefLayerPropParser.h
+6 −9 src/odb/src/lefin/lefin.cpp
+0 −1 src/odb/src/swig/common/odb.i
+0 −6 src/odb/src/swig/tcl/dbtypes.i
+0 −1 src/odb/test/BUILD
+0 −24 src/odb/test/cpp/TestLef58Properties.cpp
+0 −22 src/odb/test/data/lef58_antennagateplusdiff.lef
+0 −5 src/options.i
+11 −95 src/pad/src/RDLRouter.cpp
+1 −7 src/pad/src/RDLRouter.h
+0 −4 src/pad/src/pad.i
+1 −1 src/pad/test/rdl_route_bump_to_bump_only.defok
+0 −3 src/pdn/src/PdnGen.i
+0 −4 src/ppl/src/IOPlacer.i
+0 −4 src/psm/src/pdnsim.i
+0 −22 src/ram/src/ram.cpp
+0 −4 src/utl/src/Logger.i