Skip to content

Conversation

@r2rien
Copy link

@r2rien r2rien commented Sep 24, 2024

Just a curly brace leftover typo

Copy link
Member

@cshilwant cshilwant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR.

Your commit message misses a Signed-off-by tag - https://gerrit-review.googlesource.com/Documentation/user-signedoffby.html

Please update your commit message to include it!

@glneo
Copy link
Collaborator

glneo commented Sep 24, 2024

Is ROOTFS_DIR used anymore? Could just delete this whole line.

@r2rien
Copy link
Author

r2rien commented Sep 24, 2024

Is ROOTFS_DIR used anymore? Could just delete this whole line.

true, not used in ti-bdebstrap.
my intent was to have at least the script functional/without errors.
feel free to reject/close this MR and fix it in another way

@r2rien
Copy link
Author

r2rien commented Sep 24, 2024

Please update your commit message to include it!

Feel free to add the tag:
Signed-off-by: Antoine <[email protected]>

@glneo
Copy link
Collaborator

glneo commented Sep 25, 2024

Is ROOTFS_DIR used anymore? Could just delete this whole line.

true, not used in ti-bdebstrap. my intent was to have at least the script functional/without errors. feel free to reject/close this MR and fix it in another way

Fair enough, we can take this current patch then remove the line ourselves later if needed.

We are investigating moving away from all this custom scripting towards a more community supported solution, such as https://github.com/ilbers/isar. So these scripts might not be around at all much longer..

@r2rien
Copy link
Author

r2rien commented Sep 27, 2024

We are investigating moving away from all this custom scripting towards a more community supported

well noted that you might be moving to openembedded/yocto with isar "vendoring"
thanks for this info!
Is there any timed (even aproximately) roadmap for it ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants