Fix row height inconsistency on friends page (#495) #496
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
| </TableTd> | ||
| <TableTd style={{ textAlign: "right", padding: "7px 0px" }}> | ||
| {!isMe && ( | ||
| {isMe ? ( |
There was a problem hiding this comment.
Maybe this condition could be removed/the buttons could be combined, and then add style={{visibility: isMe ? "hidden" : undefined}} and aria-hidden={isMe ? "true" : undefined}. That way we don't need to duplicate the variant and size and text
| </TableTd> | ||
| <TableTd style={{ textAlign: "right", padding: "7px 0px" }}> | ||
| {!isMe && ( | ||
| {isMe ? ( |
There was a problem hiding this comment.
And also could add a comment for future reference, explaining why it was made like this
There was a problem hiding this comment.
And also could add a comment for future reference, explaining why it was made like this
Combined into one button and added a brief comment explaining the hidden state keeps row height consistent for the current user. Deletion behavior unchanged for other users.
|
Thank you for the contribution! |
2 participants
Fixes #495
Description
Fixed the row height inconsistency on the friends page where the current user's row was shorter than other rows.
Changes
visibility: "hidden"andaria-hidden="true"for accessibility