Skip to content

Conversation

@dpastor
Copy link
Contributor

@dpastor dpastor commented Sep 22, 2025

🎟️ Jira ticket

ANDROID-16870

πŸ₯… What's the goal?

failures reports are based on failure files extracted from the devices, in case a test is retried in the applications and it works on a second iteration, it should not be shown on the failures report.

🚧 How do we do it?

  • Filter failure logs not matching the last recorded report, so if these belong to a previous execution, these would be filtered.
  • Failure logs are just maintained if these match the last recorded report name.

πŸ“˜ Documentation changes?

  • No docs to update nor create

πŸ§ͺ How can I test this?

  • Instrumentation tests in the repository

@dpastor dpastor requested review from a team, Copilot, jeslat and pmartinbTEF and removed request for a team September 22, 2025 15:04
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes loggerazzi failure reports to correctly filter out failure logs from retried test executions that eventually succeeded. The changes ensure that only failure logs matching the last recorded report are retained, preventing false positives in failure reporting.

Key changes:

  • Consolidates filtering logic for both recorded and failure logs into a single method
  • Implements cross-directory filtering to remove failure logs that don't correspond to the latest recorded execution
  • Maintains synchronization between recorded and failure directories by using the same timestamp-based filtering

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

deviceFileManager.pullFailuresLogs(absolutePath)
processAndFilterResults()
}
filterRecordedAndFailureResults(recordedFolderFile, failuresFolderFile)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll move all fixes applied to snaptesting on a PR in that repo.

Copy link
Contributor

@jeslat jeslat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ‘

@dpastor dpastor merged commit 238f589 into main Sep 23, 2025
1 check passed
@dpastor dpastor deleted the filter_logs_correctly branch September 23, 2025 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants