ANDROID-16839 Fix loggerazzi reports #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpastor
requested review from
a team,
Copilot,
hjorrod and
jeprubio
and removed request for
a team
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the loggerazzi test framework to capture recorded logs before test failures occur. Previously, if a test failed, the recorded logs would not be generated, making debugging difficult.
- Moves log writing logic to execute before potential test failures
- Extracts log writing functionality into a dedicated private method
- Ensures recorded logs are always captured regardless of test outcome
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
loggerazzi/src/main/java/com/telefonica/loggerazzi/LoggerazziRule.kt
Outdated
Show resolved
Hide resolved
…ule.kt Co-authored-by: Copilot <[email protected]>
hjorrod
approved these changes
Sep 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Jira ticket
ANDROID-16839
🥅 What's the goal?
We should capture recorded log before crashing the test, if test fails, recorded log wont be generated.
🚧 How do we do it?
📘 Documentation changes?
🧪 How can I test this?