Skip to content

Conversation

@jdelga
Copy link
Member

@jdelga jdelga commented Dec 2, 2024

Update Android Logger dependencies

  • Use Toml file (no auto-update for now)
  • Update to Java 17
  • Update libraries

@jdelga jdelga changed the title Jdelga/update dependencies Update dependencies Dec 3, 2024
@jdelga jdelga marked this pull request as ready for review December 3, 2024 10:08
private fun setupViews() {
findViewById<Button>(R.id.button_add_logs).setOnClickListener {
(1..NUMBER_OF_LOGS_TO_ADD).forEach {
repeat(NUMBER_OF_LOGS_TO_ADD) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a newer lint issue

Copy link
Contributor

@juangardi21 juangardi21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏽 thanks!

@jdelga jdelga requested review from a team, dpastor and pmartinbTEF and removed request for a team December 3, 2024 11:46
org.gradle.parallel=true

android.useAndroidX=true
kapt.incremental.apt=true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this line deleted?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some configuration has been deprecated or removed when updating Kotlin or Gradle. In this particular case, kapt was not even used.

Copy link
Contributor

@pmartinbTEF pmartinbTEF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@jdelga jdelga merged commit c32aae9 into main Dec 4, 2024
1 check passed
@jdelga jdelga deleted the jdelga/update_dependencies branch December 4, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants