Draft
Conversation
The code for the cheese cow and a new liquid called cheese whiz, when compressed it makes a cheese wheel, still has un finish work on the liquid and spawning for the cow but I'm working on it
Put a space back
Roelymole
requested changes
Oct 2, 2025
Member
Roelymole
left a comment
There was a problem hiding this comment.
There are quite a few inconsistencies (especially with spaces). In most of these cases you should hopefully be able to get a fairly good sense of the conventions by looking at similar parts of the codebase and emulating those.
src/main/java/dev/galacticraft/mod/client/render/entity/CheeseCowEntityRender.java
Outdated
Show resolved
Hide resolved
src/main/java/dev/galacticraft/mod/client/render/entity/CheeseCowEntityRender.java
Outdated
Show resolved
Hide resolved
src/main/java/dev/galacticraft/mod/data/recipes/GCMachineRecipes.java
Outdated
Show resolved
Hide resolved
| this.advancement(Advancements.EAT_MOON_CHEESE_CURD, "Wensleydale? Stilton?", "Eat Moon Cheese Curd"); | ||
| this.advancement(Advancements.CHEESE_AND_CRACKERS, "It's Like No Cheese I've Ever Tasted...", "Eat cheese and crackers"); | ||
| this.advancement(Advancements.CHEESE_TAX, "Cheese Tax", "Give Cheese to a pet Wolf"); | ||
| this.advancement(Advancements.CHEESE_WHIZ, "Is this cheese?", "Milk a cheese cow"); |
Member
There was a problem hiding this comment.
I think something like "Hey Diddle Diddle" might make a good advancement title for something to do with a cow that is found on the Moon, although not necessarily milking one.
https://en.wikipedia.org/wiki/Hey_Diddle_Diddle
Also, the capitalization style (for English translations at least) would be to capitalize the first letter of cheese and cow to give "Milk a Cheese Cow", since "Cheese Cow" is the name of an entity.
src/main/java/dev/galacticraft/mod/content/fluid/CheeseWhizFluid.java
Outdated
Show resolved
Hide resolved
A few minor fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cheese_cow_showcase.mp4
Cheese_whiz_showcase.mp4
Compressed_cheese_whel.mp4
To Do: