Skip to content

Feat: Cheese cow!#523

Draft
reyjaz007 wants to merge 7 commits intoTeamGalacticraft:mainfrom
reyjaz007:main
Draft

Feat: Cheese cow!#523
reyjaz007 wants to merge 7 commits intoTeamGalacticraft:mainfrom
reyjaz007:main

Conversation

@reyjaz007
Copy link

  • Added a new entity, the cheese cow has a cheese crud loot table, interacting with a bucket will give you a cheese whiz bucke, texture is just a reskin of a basic cow
Cheese_cow_showcase.mp4
  • Added cheese whiz liquid, basic liquid with a new texture, missing some work
Cheese_whiz_showcase.mp4
  • Added a new cheese whel recepie. A new alternative recepie for a moon cheese whel, you will need a cheese whiz bucket and a compressor
Compressed_cheese_whel.mp4

To Do:

  • Liquid rework
  • Cheese cow naturaly spawn (moon spawn)
  • New textures?

The code for the cheese cow and a new liquid called cheese whiz, when compressed it makes a cheese wheel, still has un finish work on the liquid and spawning for the cow but I'm working on it
Put a space back
Copy link
Member

@Roelymole Roelymole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are quite a few inconsistencies (especially with spaces). In most of these cases you should hopefully be able to get a fairly good sense of the conventions by looking at similar parts of the codebase and emulating those.

this.advancement(Advancements.EAT_MOON_CHEESE_CURD, "Wensleydale? Stilton?", "Eat Moon Cheese Curd");
this.advancement(Advancements.CHEESE_AND_CRACKERS, "It's Like No Cheese I've Ever Tasted...", "Eat cheese and crackers");
this.advancement(Advancements.CHEESE_TAX, "Cheese Tax", "Give Cheese to a pet Wolf");
this.advancement(Advancements.CHEESE_WHIZ, "Is this cheese?", "Milk a cheese cow");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think something like "Hey Diddle Diddle" might make a good advancement title for something to do with a cow that is found on the Moon, although not necessarily milking one.
https://en.wikipedia.org/wiki/Hey_Diddle_Diddle

Also, the capitalization style (for English translations at least) would be to capitalize the first letter of cheese and cow to give "Milk a Cheese Cow", since "Cheese Cow" is the name of an entity.

A few minor fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants