Open
Conversation
# Conflicts: # src/api/java/dev/galacticraft/api/accessor/CryogenicAccessor.java # src/api/java/dev/galacticraft/api/registry/AcidTransformItemRegistry.java # src/api/java/dev/galacticraft/impl/internal/block/ExtinguishableBlockRegistryImpl.java # src/main/java/dev/galacticraft/impl/internal/block/ExtinguishableBlockRegistryImpl.java # src/main/java/dev/galacticraft/impl/internal/registry/ExtinguishableBlockRegistryImpl.java # src/main/java/dev/galacticraft/mod/GalacticraftClient.java # src/main/java/dev/galacticraft/mod/client/render/entity/rocket/RocketEntityRenderer.java # src/main/java/dev/galacticraft/mod/events/GCEventHandlers.java # src/main/java/dev/galacticraft/mod/misc/footprint/Footprint.java # src/main/java/dev/galacticraft/mod/mixin/EntityMixin.java # src/main/resources/fabric.mod.json
chore: add javadoc to OxygenProvidingBlock chore: move lookup registration out of entity and block classes
… into feature/api-split
…tside of development environment
Roelymole
reviewed
Dec 1, 2025
Member
There was a problem hiding this comment.
This looks like it is still WIP, so maybe it should be saved for a future PR.
Member
There was a problem hiding this comment.
This should probably be removed from this PR and maybe included in a separate PR later on.
Comment on lines
+84
to
+90
| // RocketLayout layout = entity.getRocketLayout(); | ||
| // List<Holder<? extends RocketPart<?, ?>>> parts = layout.parts().stream().map(eitherHolder -> maybeGet(entity, eitherHolder)); | ||
| // | ||
| // for (EitherHolder<? extends RocketPart<?, ?>> part : layout.parts()) { | ||
| // part. | ||
| // } | ||
|
|
Comment on lines
+703
to
+707
| // @Override | ||
| // public @NotNull RocketLayout getRocketLayout() { | ||
| // return getRocketData().layout(); | ||
| // } | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reintroduces the API has a separate source set of the mod similar to how the old GC-API worked.
Currently the API doesn't have its own mod id/fmj.
However this may be changed depending on future API plans.
My main reason for creating this is to prevent accidental GC Mod code in the API, and also allow addons to use the api without depending on GC itself