Skip to content

Add support to Google Places API (New) #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
andreia merged 3 commits into from
Jan 5, 2025
Merged

Add support to Google Places API (New) #11

andreia merged 3 commits into from
Jan 5, 2025

Conversation

@andreia
Copy link
Member

@andreia andreia commented Jan 5, 2025

Add the ->placesApiNew() method to use the Places API (new) instead of original:

GoogleAutocomplete::make('google_search')
    ->placesApiNew()

@andreia andreia requested a review from swilla January 5, 2025 00:31
swilla
swilla requested changes Jan 5, 2025
View reviewed changes
Copy link
Member

@swilla swilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one change

config/filament-google-autocomplete-field.php Outdated
return [

'api-key' => env('GOOGLE_PLACES_API_KEY', ''),
'verify-ssl' => false,
Copy link
Member

@swilla swilla Jan 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should default this to true.

Copy link
Member Author

@andreia andreia Jan 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just updated :)

@andreia andreia requested a review from swilla January 5, 2025 01:02
@andreia andreia merged commit 97cad7b into main Jan 5, 2025
7 checks passed
@andreia andreia mentioned this pull request Jan 5, 2025
Closed
@swilla swilla deleted the add_new_place_api branch February 10, 2025 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@swilla swilla swilla approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@andreia @swilla