test(query-core): replace 'async/await sleep' with 'sleep().then()' in test 'queryFn' and 'mutationFn' by sukvvon · Pull Request #10435 · TanStack/query

sukvvon · 2026-04-09T01:16:05Z

🎯 Changes

Replace async () => { await sleep(N); return value } with () => sleep(N).then(() => value) in test queryFn and mutationFn
Applied to hydration.test.tsx, mutations.test.tsx, queriesObserver.test.tsx, query.test.tsx, queryClient.test.tsx, queryObserver.test.tsx

✅ Checklist

I have followed the steps in the Contributing guide.
I have tested this code locally with pnpm run test:pr.

🚀 Release Impact

This change affects published code, and I have generated a changeset.
This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

Tests
- Refactored test implementations across multiple test suites to use promise chains instead of async/await syntax, maintaining identical test behavior and assertions.

Note: These are internal test-code updates with no impact to end-user functionality or features.

…n test 'queryFn' and 'mutationFn'

coderabbitai · 2026-04-09T01:16:23Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 20f62421-b9d2-4e51-b7bd-5db451dc7e6d

📥 Commits

Reviewing files that changed from the base of the PR and between 6b95cd8 and bb611da.

📒 Files selected for processing (6)

packages/query-core/src/__tests__/hydration.test.tsx
packages/query-core/src/__tests__/mutations.test.tsx
packages/query-core/src/__tests__/queriesObserver.test.tsx
packages/query-core/src/__tests__/query.test.tsx
packages/query-core/src/__tests__/queryClient.test.tsx
packages/query-core/src/__tests__/queryObserver.test.tsx

📝 Walkthrough

Walkthrough

This PR systematically refactors test query function implementations across multiple test files in query-core, replacing async/await with explicit promise chains using .then(), while maintaining identical timing and resolved values.

Changes

Cohort / File(s)	Summary
Test Query Function Refactoring `packages/query-core/src/__tests__/hydration.test.tsx`, `mutations.test.tsx`, `queriesObserver.test.tsx`, `query.test.tsx`, `queryClient.test.tsx`, `queryObserver.test.tsx`	Replaced `async` functions with `await sleep(...)` syntax with non-async arrow functions returning `sleep(...).then(...)` chains. Preserves timing semantics and resolved values across hydration, mutation, observer, and query client tests.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

test(preact-query): replace 'async/await sleep' with 'sleep().then()' in test 'queryFn' and 'mutationFn' #10400: Applies identical async/await-to-promise-chain refactoring across different package test suites
test(angular-query-experimental): replace 'async/await sleep' with 'sleep().then()' in test 'queryFn' and 'mutationFn' #10404: Performs the same test-only refactor pattern of replacing async/await sleep implementations with promise chaining

Suggested labels

package: query-core

Poem

🐰 Async dreams now chain so neat,
From await's grasp to .then() sweet,
Tests still sleep, no change in beat,
Just syntax sips of promise treat!

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: replacing async/await sleep patterns with promise chaining in test query and mutation functions across multiple test files.
Description check	✅ Passed	The description follows the template structure with completed 🎯 Changes section detailing specific transformations and affected files, and 🚀 Release Impact section correctly marked as dev-only. However, the testing checklist item remains unchecked.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch test/query-core-replace-async-await-sleep-with-then-chaining

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

nx-cloud · 2026-04-09T01:16:39Z

View your CI Pipeline Execution ↗ for commit bb611da

Command	Status	Duration	Result
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	55s	View ↗

☁️ Nx Cloud last updated this comment at 2026-04-09 01:23:18 UTC

github-actions · 2026-04-09T01:16:58Z

🚀 Changeset Version Preview

No changeset entries found. Merging this PR will not cause a version bump for any packages.

pkg-pr-new · 2026-04-09T01:19:51Z

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@10435

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@10435

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@10435

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@10435

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@10435

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@10435

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@10435

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@10435

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@10435

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@10435

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@10435

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@10435

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@10435

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@10435

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@10435

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@10435

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@10435

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@10435

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@10435

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@10435

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@10435

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@10435

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@10435

commit: bb611da

github-actions · 2026-04-09T01:20:00Z

size-limit report 📦

Path	Size
react full	11.98 KB (0%)
react minimal	9.01 KB (0%)

test(query-core): replace 'async/await sleep' with 'sleep().then()' i…

bb611da

…n test 'queryFn' and 'mutationFn'

github-actions bot added the package: query-core label Apr 9, 2026

sukvvon self-assigned this Apr 9, 2026

sukvvon merged commit 48c3975 into main Apr 9, 2026
13 of 14 checks passed

sukvvon deleted the test/query-core-replace-async-await-sleep-with-then-chaining branch April 9, 2026 01:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

test(query-core): replace 'async/await sleep' with 'sleep().then()' in test 'queryFn' and 'mutationFn'#10435

test(query-core): replace 'async/await sleep' with 'sleep().then()' in test 'queryFn' and 'mutationFn'#10435
sukvvon merged 1 commit intomainfrom
test/query-core-replace-async-await-sleep-with-then-chaining

sukvvon commented Apr 9, 2026 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Apr 9, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested labels

Poem

Uh oh!

nx-cloud bot commented Apr 9, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Apr 9, 2026

Uh oh!

pkg-pr-new bot commented Apr 9, 2026

Uh oh!

github-actions bot commented Apr 9, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

sukvvon commented Apr 9, 2026 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎯 Changes

✅ Checklist

🚀 Release Impact

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Apr 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested labels

Poem

Uh oh!

nx-cloud bot commented Apr 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Apr 9, 2026

🚀 Changeset Version Preview

Uh oh!

pkg-pr-new bot commented Apr 9, 2026

Uh oh!

github-actions bot commented Apr 9, 2026

size-limit report 📦

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

sukvvon commented Apr 9, 2026 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Apr 9, 2026 •

edited

Loading

nx-cloud bot commented Apr 9, 2026 •

edited

Loading