Up to date - update #31
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#30
Dear Gert and Freek,
First of all, thanks for creating this library. During the course of my PhD at ITC, I have used this repository for generating Sentinel-1 interferograms.
Over the course of last 6 years, a lot of dependencies have changed, for instance: URL to SRTM DEMs and URLs to Sentinel-1 orbit data. I have tried to make this repository up-to-date as on this post date.
There have been several other changes, some of which have been experimental, e.g. def.oversample() for testing oversampling of S1 data, some have been to add parentheses to the print command.
A major correction has been made in the geoidal undulation correction step in the create_dem() function. Also, the correct H2PH variable has been added in the input card generation template.
Minor changes w.r.t. import statements, compiler choices, etc. have also been done.
There might have been some updates with the same statements. Please ignore them. Please also ignore the changes made in the referencephase.cc file.
Could you please review my changes and add them to the main branch as you deem fit?
Kind regards,
Anurag Kulshrestha