Skip to content

Conversation

@harrisonlabollita
Copy link
Collaborator

I've added wannier_hr to be saved in dft_input. This amounts to adding this as an entry in things_to_save. The H(R) object is relatively small to save and having access to it without needing the original seedname_hr.dat will be useful for future TRIQS applications.

@the-hampel
Copy link
Member

Hi @harrisonlabollita,
yes we can definitely add the H(r) to the hdf5 file. I think typically we stored files that are not part of all DFT code converters into dft_misc_input so we should think about moving the H(r) there. Also please take a look at the tests. They do expect a matching hdf5 reference file, which is now of course missing the stored new entry.

And finally, it would be good to amend https://github.com/TRIQS/dft_tools/blob/3.3.x/doc/h5structure.rst with the new H(r) entry! Afterwards I am happy to merge this into unstable.

Best,
Alex

@harrisonlabollita
Copy link
Collaborator Author

Hi @the-hampel,

Thanks for having a look at this. Moving the H(R) to dft_misc_input seems most appropriate. I'll make the corresponding changes to the h5structure.rst and update the tests accordingly.

Best,
Harry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants