Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary & Motivation
Self-review
General
TEAMster Asana Project
dbt
Include a corresponding
[model name].ymlproperties file for all models.These can be generated by running
dbt run-operation generate_model_yaml --args '{"model_names": ["MODEL NAME"]}'and saving the console output to a YAML file.
Include (or update) an
exposure for all
models that will be consumed by a dashboard, analysis, or application:
Dagster "kinds" Reference
SQL
Use the
union_dataset_join_clause()macro for queries that employ modelsthat use regional datasets
Do not use
group bywithout any aggregations when you mean to usedistinctAll
distinctusage must be accompanied by an comment explaining it'snecessity
Do not use
order byforselectstatements. That should be done in thereporting layer.
If you are adding a new external source, before building, run:
Troubleshooting