Fix builds on paths containing spaces#823
Draft
IvanDSM wants to merge 2 commits intoTASEmulators:masterfrom
Draft
Fix builds on paths containing spaces#823IvanDSM wants to merge 2 commits intoTASEmulators:masterfrom
IvanDSM wants to merge 2 commits intoTASEmulators:masterfrom
Conversation
This small commit just adds quotes around the Lua source path in the include statement when using the internal Lua engine. Without these quotes, my build was breaking when the FCEUX source was located in a path that contained spaces (e.g. "/home/ivan/Software/Source Code/fceux").
IvanDSM
changed the title
Author
|
There are more issues, so I've converted this to a draft PR for now. Sorry for the over-eager PR creation! |
As with the Lua include issue, this script also needed quotes added in order to make building in paths with spaces possible.
Author
|
Seems like the most recent build failure in the Win64 and MacOS builds were due to a timeout... The MacOS build failure in my first commit seemed unrelated to my change... For what it's worth I didn't do anything to the Windows version of genGitHdr as I'm not currently on Windows, but I'll try spinning up a Windows VM and seeing if this is also an issue there. If so, I'll try and fix that too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR just adds quotes around the Lua source path in the include statement when using the internal Lua engine. Without these quotes, my build was breaking when the FCEUX source was located in a path that contained spaces (e.g. "/home/ivan/Software/Source Code/fceux").