Add driver Switch-AdvancedMicrofluidics_LSPone-Series

[franz-sweepMe]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @franz-sweepMe, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request delivers a complete new device driver for the AdvancedMicrofluidics LSPone-Series pumps. It integrates the amfTools library to facilitate communication and control, offering a robust solution for automating microfluidic experiments. The driver supports a wide range of operational parameters and provides clear documentation, making it ready for immediate use within the SweepMe! measurement environment.

Highlights

• New Device Driver: Introduces a new driver for the AdvancedMicrofluidics LSPone-Series pumps, enabling integration with the SweepMe! platform.
• Comprehensive Control: Provides extensive control over pump operations, including volume and flow rate management, valve positioning with different movement strategies, and various speed and force settings.
• Detailed Documentation: Includes a description.md file outlining setup instructions, configurable parameters, returned measurement variables, and general behavior notes for the device.
• Dependency Management: Incorporates necessary third-party libraries (amfTools, ftd2xx) along with their respective license files and a requirements.txt for amftools.
• GUI Integration: Implements update_gui_parameters and apply_gui_parameters methods for seamless interaction with the SweepMe! graphical user interface, allowing dynamic parameter configuration.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds a new driver for the AdvancedMicrofluidics LSPone-Series pump. The implementation is a good start, but there are several areas for improvement.

My review includes feedback on:

• Correctness and Robustness: I've pointed out a TODO that needs to be resolved to ensure correct data is returned, a busy-wait loop that should be fixed to avoid high CPU usage, and an overly broad exception handler that could mask bugs.
• Maintainability: I've suggested removing dead code and refactoring a conditional block to improve readability and robustness.
• Documentation: There are a couple of minor issues in the documentation, including a typo and a potentially misleading statement about unit conversion.

Please review the detailed comments for specific suggestions.