-
Notifications
You must be signed in to change notification settings - Fork 11
SMU-Agilent_415x -> add VSU channels #217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @franz-sweepMe, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces support for Voltage Source Unit (VSU) channels on the Agilent 415x parameter analyzer. The changes enable users to select and utilize VSU channels for voltage sourcing, while correctly disabling measurement functionalities and current sourcing, aligning with the hardware's capabilities. This enhancement provides more comprehensive control over the instrument's various channel types by integrating VSU channels into the existing driver architecture. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds support for VSU channels to the Agilent 415x driver, enabling voltage sourcing and preventing measurement operations on these channels. However, a high-severity command injection vulnerability was identified where the source parameter, derived from user input, is not properly sanitized, potentially allowing arbitrary commands to be executed on the instrument. Additionally, there are suggestions to improve channel parsing robustness, fix a variable usage bug, and enhance code consistency and documentation.
5d5f6a5 to
244492e
Compare
244492e to
eb3b5df
Compare
VSU allow only to source voltage, so no measured values are returned