fix issue #539 #1054
Open
fix issue #539 #1054
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit 010e62e and detected 2 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
Author
|
@codegsaini Hi! I refactored it in bf63f0e. I think it can pass complexity analysis now? |
codegsaini
reviewed
Apr 23, 2022
codegsaini
approved these changes
Apr 23, 2022
Contributor
codegsaini
left a comment
codegsaini
left a comment
There was a problem hiding this comment.
This PR looks good. @Swati4star Can consider final review on it before merging.
Happy coding :)
Author
|
@codegsaini It should work now. Thank you for the code review! |
Swati4star
requested changes
May 17, 2023
Owner
Swati4star
left a comment
Swati4star
left a comment
There was a problem hiding this comment.
Can you fix the merge conflicts?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the bug that after compression pdf becomes larger. Now the compressed file is always smaller than the original one, and the setting for the compression rate is more effective. No dependency changed.
Fixes #539
Type of change
How Has This Been Tested?
Test compressing pdf with following three:
book_sample.pdf
pdf_with_big_pic.pdf
pdf_with_pic_hard_to_compress.pdf
./gradlew assembleDebug assembleRelease./gradlew checkstyleChecklist: