Support all the BoundPoseTypes [HL2VR / Township Tale / Valheim VR] #234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arning for unsupported non-raw pose types Signed-off-by: Mats Huesmann <[email protected]>
Contributor
Author
|
Since there are more poses that can be defined on a per-controller basis for different controllers. Maybe instead of the type, we should just add a pose offset property that gets filled on load and raw just is an empty offset? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Add new BoundPoseType variants, update pose parsing logic and warning for unsupported non-raw pose types
fixes: