Link to system OpenXR instead of static compiling #202
+5
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SpookySkeletons
force-pushed
the
patch-1
branch
from
80bdc1c to
230280b
Compare
Contributor
Author
|
Modified the CI to also pull in the OpenXR 1.0.20 headers for the build. |
Owner
|
Thinking about this, I think I'd like if this was behind a feature (that can be on by default). |
SpookySkeletons
force-pushed
the
patch-1
branch
from
230280b to
fdc24eb
Compare
Contributor
Author
|
Feature gated and defaulted on |
Contributor
Author
|
CI refusing external changes to the build. |
Supreeeme
reviewed
Dec 5, 2025
|
|
||
| [features] | ||
| default = ["openxr-dynamic"] | ||
| openxr-dynamic = ["openxr/linked", "openvr/openxr-dynamic"] |
Owner
There was a problem hiding this comment.
With the flags like this it's impossible to get static openxr anymore. It seems that the static flag actually implies linked, so maybe it should instead be a openxr-static feature and set features = ["linked"] on the openxr dependency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To my awareness, Proton should now deal with this correctly, as should we.