Skip to content

Conversation

@Crabcyborg
Copy link
Contributor

@Crabcyborg Crabcyborg commented Jan 7, 2026

It looks like ranking fields were causing form validation issues.

I think we should probably ignore ranking fields as well since they're similar to the other skipped field types (radio, checkbox, select).

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 7, 2026

Walkthrough

The PR adds 'ranking' to the skip_field_types array in the fill_default_denylist_data function of FrmSpamCheckDenylist.php, extending the set of field types excluded from spam denylist checking.

Changes

Cohort / File(s) Summary
Spam Denylist Configuration
classes/models/FrmSpamCheckDenylist.php
Added 'ranking' to skip_field_types array in fill_default_denylist_data, preventing spam denylist checks on ranking field types

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: adding ranking fields to the denylist skip list, which matches the code modification in FrmSpamCheckDenylist.php.
Description check ✅ Passed The description is relevant to the changeset, explaining why ranking fields should be skipped (form validation issues) and how they're similar to other skipped field types.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Crabcyborg Crabcyborg changed the title Add ranking and likert fields to denylist skip list Add ranking fields to denylist skip list Jan 7, 2026
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In @classes/models/FrmSpamCheckDenylist.php:
- Line 234: In FrmSpamCheckDenylist.php update the skip_field_types array (the
array containing 'password', 'captcha', 'signature', 'checkbox', 'radio',
'select', 'ranking') to also include 'likert' so the array matches
FrmEntryValidate.php's behavior; locate the array literal in the
FrmSpamCheckDenylist class and append 'likert' to the list of skipped field
types.
📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c5d0daa and e6fcf65.

📒 Files selected for processing (1)
  • classes/models/FrmSpamCheckDenylist.php
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: Cypress
  • GitHub Check: PHP 7.4 tests in WP 6.9
  • GitHub Check: PHP 8 tests in WP 6.9

Copy link
Contributor

@truongwp truongwp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Thanks @Crabcyborg!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants