-
Notifications
You must be signed in to change notification settings - Fork 39
Add ranking fields to denylist skip list #2728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
WalkthroughThe PR adds 'ranking' to the skip_field_types array in the fill_default_denylist_data function of FrmSpamCheckDenylist.php, extending the set of field types excluded from spam denylist checking. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In @classes/models/FrmSpamCheckDenylist.php:
- Line 234: In FrmSpamCheckDenylist.php update the skip_field_types array (the
array containing 'password', 'captcha', 'signature', 'checkbox', 'radio',
'select', 'ranking') to also include 'likert' so the array matches
FrmEntryValidate.php's behavior; locate the array literal in the
FrmSpamCheckDenylist class and append 'likert' to the list of skipped field
types.
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
classes/models/FrmSpamCheckDenylist.php
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Cypress
- GitHub Check: PHP 7.4 tests in WP 6.9
- GitHub Check: PHP 8 tests in WP 6.9
truongwp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. Thanks @Crabcyborg!
It looks like ranking fields were causing form validation issues.
I think we should probably ignore ranking fields as well since they're similar to the other skipped field types (radio, checkbox, select).